Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cherry-pick to 0.9: del metadata sync && del duplicate metrics (#3380) #3738

Merged

Conversation

TrafalgarZZZ
Copy link
Member

Ⅰ. Describe what this PR does

Cherry-pick #3380 to release-0.9.

#3380 fixes JuiceFSRuntime controller's OOM issue when there is large amount of files.

Ⅱ. Does this pull request fix one issue?

NONE

Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

* del metadata sync && del duplicate metrics

Signed-off-by: zwwhdls <zww@hdls.me>

* log level

Signed-off-by: zwwhdls <zww@hdls.me>

---------

Signed-off-by: zwwhdls <zww@hdls.me>
Signed-off-by: trafalgarzzz <trafalgarz@outlook.com>
Copy link

sonarcloud bot commented Feb 28, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

codecov bot commented Feb 28, 2024

Codecov Report

Attention: Patch coverage is 79.31034% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 65.52%. Comparing base (02f70ac) to head (1bc90cd).
Report is 4 commits behind head on release-0.9.

Files Patch % Lines
pkg/ddc/juicefs/cache.go 69.23% 2 Missing and 2 partials ⚠️
pkg/ddc/juicefs/operations/base.go 87.50% 2 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##           release-0.9    #3738      +/-   ##
===============================================
+ Coverage        65.43%   65.52%   +0.09%     
===============================================
  Files              398      398              
  Lines            23151    23115      -36     
===============================================
- Hits             15149    15147       -2     
+ Misses            6217     6183      -34     
  Partials          1785     1785              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@cheyang cheyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Copy link

fluid-e2e-bot bot commented Feb 28, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cheyang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fluid-e2e-bot fluid-e2e-bot bot merged commit 212d6e8 into fluid-cloudnative:release-0.9 Feb 28, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants