Fix the problem of using option to append Dataset public option #3454
Conversation
|
Hi @lgy1027. Thanks for your PR. I'm waiting for a fluid-cloudnative member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: lgy1027 <lgy10271416@gmail.com>
| @@ -372,8 +372,8 @@ func (e *AlluxioEngine) genUFSMountOptions(m datav1alpha1.Mount, SharedOptions m | |||
|
|
|||
| // initialize alluxio mount options | |||
| mOptions := map[string]string{} | |||
| if len(SharedOptions) > 0 { | |||
| mOptions = SharedOptions | |||
| for k, v := range SharedOptions { | |||
There was a problem hiding this comment.
Could you also add unit test for the fix? thanks very much!
There was a problem hiding this comment.
I have added unit test: generating UFS mount options multiple times via functions genUFSMountOptions in AlluxioEngine
Signed-off-by: ZhangXiaozheng <zhang__xiaozheng@outlook.com>
|
Kudos, SonarCloud Quality Gate passed!
|
Codecov Report
@@ Coverage Diff @@
## master #3454 +/- ##
==========================================
+ Coverage 64.24% 64.28% +0.03%
==========================================
Files 442 442
Lines 26441 26452 +11
==========================================
+ Hits 16988 17005 +17
+ Misses 7444 7441 -3
+ Partials 2009 2006 -3
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cheyang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Thanks very much for your contribution, @lgy1027 @zhang-x-z |
…d-cloudnative#3454) * Fix the problem of using option to append Dataset public option Signed-off-by: lgy1027 <lgy10271416@gmail.com> * Add Unit Test for alluxio engine genUFSMountOptions Signed-off-by: ZhangXiaozheng <zhang__xiaozheng@outlook.com> --------- Signed-off-by: lgy1027 <lgy10271416@gmail.com> Signed-off-by: ZhangXiaozheng <zhang__xiaozheng@outlook.com> Co-authored-by: liguoyu3564 <liguoyu@leinao.ai> Co-authored-by: ZhangXiaozheng <zhang__xiaozheng@outlook.com>
…d-cloudnative#3454) * Fix the problem of using option to append Dataset public option Signed-off-by: lgy1027 <lgy10271416@gmail.com> * Add Unit Test for alluxio engine genUFSMountOptions Signed-off-by: ZhangXiaozheng <zhang__xiaozheng@outlook.com> --------- Signed-off-by: lgy1027 <lgy10271416@gmail.com> Signed-off-by: ZhangXiaozheng <zhang__xiaozheng@outlook.com> Co-authored-by: liguoyu3564 <liguoyu@leinao.ai> Co-authored-by: ZhangXiaozheng <zhang__xiaozheng@outlook.com> Signed-off-by: cheyang <cheyang@163.com>
… (#3459) * Fix the problem of using option to append Dataset public option (#3454) * Fix the problem of using option to append Dataset public option Signed-off-by: lgy1027 <lgy10271416@gmail.com> * Add Unit Test for alluxio engine genUFSMountOptions Signed-off-by: ZhangXiaozheng <zhang__xiaozheng@outlook.com> --------- Signed-off-by: lgy1027 <lgy10271416@gmail.com> Signed-off-by: ZhangXiaozheng <zhang__xiaozheng@outlook.com> Co-authored-by: liguoyu3564 <liguoyu@leinao.ai> Co-authored-by: ZhangXiaozheng <zhang__xiaozheng@outlook.com> Signed-off-by: cheyang <cheyang@163.com> * Fix api issue for genUFSMountOptions, To #51793350 Signed-off-by: cheyang <cheyang@163.com> --------- Signed-off-by: lgy1027 <lgy10271416@gmail.com> Signed-off-by: ZhangXiaozheng <zhang__xiaozheng@outlook.com> Signed-off-by: cheyang <cheyang@163.com> Co-authored-by: li_max <lgy10271416@gmail.com> Co-authored-by: liguoyu3564 <liguoyu@leinao.ai> Co-authored-by: ZhangXiaozheng <zhang__xiaozheng@outlook.com>
…d-cloudnative#3454) * Fix the problem of using option to append Dataset public option Signed-off-by: lgy1027 <lgy10271416@gmail.com> * Add Unit Test for alluxio engine genUFSMountOptions Signed-off-by: ZhangXiaozheng <zhang__xiaozheng@outlook.com> --------- Signed-off-by: lgy1027 <lgy10271416@gmail.com> Signed-off-by: ZhangXiaozheng <zhang__xiaozheng@outlook.com> Co-authored-by: liguoyu3564 <liguoyu@leinao.ai> Co-authored-by: ZhangXiaozheng <zhang__xiaozheng@outlook.com>
Fix error when using sharedOptions to mount multiple mounts