Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the problem of using option to append Dataset public option (#3454) #3459

Conversation

cheyang
Copy link
Collaborator

@cheyang cheyang commented Sep 16, 2023

  • Fix the problem of using option to append Dataset public option

  • Add Unit Test for alluxio engine genUFSMountOptions


Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

fixes #XXXX

Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@fluid-e2e-bot
Copy link

fluid-e2e-bot bot commented Sep 16, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from cheyang by writing /assign @cheyang in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

…d-cloudnative#3454)

* Fix the problem of using option to append Dataset public option

Signed-off-by: lgy1027 <lgy10271416@gmail.com>

* Add Unit Test for alluxio engine genUFSMountOptions

Signed-off-by: ZhangXiaozheng <zhang__xiaozheng@outlook.com>

---------

Signed-off-by: lgy1027 <lgy10271416@gmail.com>
Signed-off-by: ZhangXiaozheng <zhang__xiaozheng@outlook.com>
Co-authored-by: liguoyu3564 <liguoyu@leinao.ai>
Co-authored-by: ZhangXiaozheng <zhang__xiaozheng@outlook.com>
Signed-off-by: cheyang <cheyang@163.com>
@cheyang cheyang force-pushed the sharedOptions_issue_for_release_0.9 branch from 76237e7 to 1d09bfe Compare September 16, 2023 03:36
Signed-off-by: cheyang <cheyang@163.com>
@sonarcloud
Copy link

sonarcloud bot commented Sep 16, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov
Copy link

codecov bot commented Sep 16, 2023

Codecov Report

Merging #3459 (b042f61) into release-0.9 (7b01a4c) will not change coverage.
The diff coverage is 100.00%.

❗ Current head b042f61 differs from pull request most recent head 4065cc4. Consider uploading reports for the commit 4065cc4 to get more accurate results

@@             Coverage Diff              @@
##           release-0.9    #3459   +/-   ##
============================================
  Coverage        65.43%   65.43%           
============================================
  Files              398      398           
  Lines            23151    23151           
============================================
  Hits             15149    15149           
  Misses            6217     6217           
  Partials          1785     1785           
Files Changed Coverage Δ
pkg/ddc/alluxio/ufs_internal.go 52.17% <100.00%> (ø)

@cheyang cheyang merged commit 02f70ac into fluid-cloudnative:release-0.9 Sep 18, 2023
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants