FLUID-6121: Documenting Infusion 2.0 deprecations. #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amb26
reviewed
Feb 2, 2017
src/documents/DeprecatedIn2_0.md
Outdated
| </tr> | ||
| <tr> | ||
| <td>no JavaScript version of <code>fluid.uploader</code></td> | ||
| <td>See [Infusion 2.0](https://github.com/fluid-project/infusion/blob/infusion-2.0/src/components/uploader/html/Uploader.html#L37-L41) as an example for creating a custom fallback.</td> |
There was a problem hiding this comment.
This link should use an HTML style since it is within a table
amb26
reviewed
Feb 2, 2017
src/documents/DeprecatedIn2_0.md
Outdated
|
|
||
| This page contains a list of the features, APIs, and etc. that are deprecated as of Infusion 2.0. | ||
|
|
||
| <div class="infusion-docs-note"><strong>Note:</strong> While the intention is to provide advanced notice of future changes, the contents of this page may not be exhaustive.</div> |
There was a problem hiding this comment.
Properly this should be "advance notice": http://grammarist.com/usage/advance-advanced/
|
@amb26 thanks, made those changes. ready for another look. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.fluidproject.org/browse/FLUID-6121
Please merge both into master and the 2.x.x branch.