SJRK-447: Switch to fluid-lint-all #107
Conversation
|
Actually there may be a new release of fluid-lint-all coming soon that will make the configuration a bit easier by automatically excluding the images and etc. We should check the state of that before merging this. If it's available or will be soon, we can hold off. Otherwise we can make improvements later. |
| "eslint-config-fluid": "2.0.0", | ||
| "eslint-plugin-jsdoc": "30.7.8", |
There was a problem hiding this comment.
Since eslint-config-fluid and eslint-plugin-jsdoc have already been dependencies of fluid-lint-all, is it necessary to include them again as dependencies of this repo?
There was a problem hiding this comment.
We recommend for "eslint-config-fluid" that you explicitly also depend on "eslint-plugin-jsdoc" if you use it. The issue is that there are problems with packaging an eslint plugin with the shareable config. See eslint/eslint#3458 They are working on a new config format to address this. See: eslint/eslint#13481
I'm not sure if the fluid-lint-all suffers from similar issues related to "eslint-config-fluid" there is a reference to install it in the fluid-lint-all README which I took as meaning that you should separately install it.
There was a problem hiding this comment.
I see. Thanks for the explanation, @jobara.
|
This pull request looks good to me. |
|
Merged at a958887 |
https://issues.fluidproject.org/browse/SJRK-447
This PR is based off of work in #105