Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor/flake db #789

Closed
wants to merge 16 commits into from
Closed

Refactor/flake db #789

wants to merge 16 commits into from

Conversation

zonotope
Copy link
Contributor

This patch is part of a series that reorganizes the code in light of the new db types. This patch renames the JsonLdDb record to FlakeDB, and puts the namespace that defines that record as well as all of it's supporting namespace under the fluree.db.flake.... namespace hierarchy. I think JsonLdDb is ambiguous because all of our DB types represent json-ld data, but I think FlakeDB is more precise to how this specific DB type represents that data.

@zonotope zonotope requested a review from a team May 30, 2024 12:48
Copy link
Contributor

@dpetran dpetran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Base automatically changed from feature/dataset-protocol-impls to main June 1, 2024 16:09
@zonotope zonotope changed the base branch from main to refactor/db-api-ns June 25, 2024 17:51
Copy link
Contributor

@dpetran dpetran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

Base automatically changed from refactor/db-api-ns to main July 9, 2024 16:21
@zonotope
Copy link
Contributor Author

closing in favor of #842 and #844

@zonotope zonotope closed this Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants