Refactor/db protocol implementations #844
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We've temporarily disabled simple subject crawl until we (re)introduce a generalized query optimization framework
dpetran
reviewed
Jul 18, 2024
This avoids two nested calls to `satisfies?` which is slower than the calls to `map?` and `sequential?` that replaces it.
This reverts commit dbc931e. This commit doesn't work because `map?` returns true for clojure records, which all database instances are. I don't think the calls to `satisfies?` can be avoided unfortunately.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch is the second in a series of replacements for #789 that cleans up some of the
FlakeDBprotocol implementations (more work to be done on that front later) and adds a new protocol for reasoning. The reasoning api functions currently in main operate on aFlakeDBdirectly, so they would break if they were ever called on anAsyncDB.