Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

form_builder_phone_field update #1040

Merged
merged 12 commits into from
Jun 14, 2022
Merged

Conversation

deandreamatias
Copy link
Collaborator

Connection with issue(s)

Connected to #855

Testing and Review Notes

  • Test with Flutter 2.8.1 and 2.10.5

Next steps:

  • Publish to pub.dev with version 1.0.0

Screenshots or Videos

image
image

To Do

  • double check the original issue to confirm it is fully satisfied
  • add testing notes and screenshots in PR description to help guide reviewers
  • request the "UX" team perform a design review (if/when applicable)

@danvick
Copy link
Collaborator

danvick commented Jun 14, 2022

@deandreamatias are we done here? Looks good to me. I'm ready to publish

@deandreamatias
Copy link
Collaborator Author

deandreamatias commented Jun 14, 2022

Yes! Nice changes

After this, I will do another pull request to be compatible with last version of flutter_form_builder and Flutter 3.0. But this is the future...

This PR can will be merge

@danvick danvick merged commit ececc01 into master Jun 14, 2022
@danvick danvick deleted the form_builder_phone_field/update branch June 14, 2022 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants