Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

when calls currentstate.value`the value is empty #86

Closed
wants to merge 1 commit into from
Closed

Conversation

cacianokroth
Copy link

Because values ​​are not being assigned to the getter.

Because values ​​are not being assigned to the getter.
@danvick
Copy link
Collaborator

danvick commented Jun 28, 2019

Hi @cacianokroth,
Thanks for the good eye and your consequent contribution.

Omission of the line you've added was intentional. This is because the line _fieldKeys[attribute].currentState.didChange(value); will change FormField value and the data will be saved when the save() function of the FormField will be called - just like the rest of the fields.

Also still think - as stated earlier - that the API for setAttributeValue is still not ready as it changes the value of the FormField without effecting the change through to the UI.
Since I published the function by mistake, I'm planning to deprecate it till when we find a way of propagating the change to the UI.

@danvick
Copy link
Collaborator

danvick commented Jul 3, 2019

Hi @cacianokroth,
I'm genuinely sorry, I may have overlooked the importance of your PR.
Thanks very much for contributing, I'll be more careful when reviewing code next time.

Cheers!.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants