Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fill-extrusion support #1095

Closed
wants to merge 17 commits into from
Closed

Conversation

mrcrow
Copy link

@mrcrow mrcrow commented Jun 17, 2022

  1. Fixed issues in generate.dart that the template file locations and output file locations are always incorrect
  2. Fixed a bug in generate.dart that parse will crash in function buildSourceProperty (please take a look at this issue)
  3. Add type camel to support generate iOS template file
  4. Add iOS/Android/web fill-extrusion function

@felix-ht
Copy link
Collaborator

@mrcrow please fix the formatting (see github actions)

@QuangNguyen240498
Copy link

@mrcrow hope this feature will be done soon

@mrcrow
Copy link
Author

mrcrow commented Jun 27, 2022

@felix-ht I didn't see any error description about the failed check, just a error code 1, what's the meaning of that? Any suggestion?

@m0nac0
Copy link
Collaborator

m0nac0 commented Jun 28, 2022

@mrcrow You need to run formatting for all files listed explicitly in the failed "check ... formatting" step logs. E.g. for Swift you need to format LayerPropertyConverter.swift and MapboxMapController.swift

The formatting commands are listed in https://github.com/flutter-mapbox-gl/maps/blob/master/.github/workflows/flutter_ci.yml (for java remove the -n option to actually perform the reformatting, not only a dry run)

@mrcrow mrcrow had a problem deploying to ANDROID_CI_DOWNLOADS_TOKEN July 14, 2022 11:17 Failure
@mrcrow mrcrow had a problem deploying to ANDROID_CI_DOWNLOADS_TOKEN July 14, 2022 11:17 Failure
@Snuff777 Snuff777 had a problem deploying to ANDROID_CI_DOWNLOADS_TOKEN July 18, 2022 17:24 Failure
@Snuff777 Snuff777 had a problem deploying to ANDROID_CI_DOWNLOADS_TOKEN July 18, 2022 17:25 Failure
@stale
Copy link

stale bot commented Sep 16, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Sep 16, 2022
@m0nac0 m0nac0 added the pinned label Sep 23, 2022
@stale stale bot removed the stale label Sep 23, 2022
@mrcrow
Copy link
Author

mrcrow commented Sep 24, 2022

Hi everyone, it seems difficult for me and my partner to accomplish the CI workflow, anyone can help us to upload the code again and go through this checking workflow? I don't want this feature to be delayed any longer

@felix-ht

@felix-ht
Copy link
Collaborator

Will take a look on Monday

@mrcrow
Copy link
Author

mrcrow commented Sep 25, 2022

Will take a look on Monday

Thanks @felix-ht

@felix-ht
Copy link
Collaborator

felix-ht commented Sep 27, 2022

This diff should fix the issues:
please use make format instead
Apply this to your branch

@felix-ht
Copy link
Collaborator

@mrcrow please rebease on master to fix the ci

#1181 added a makefile to help with formatting

@felix-ht
Copy link
Collaborator

closed in favor of #1187

@felix-ht felix-ht closed this Oct 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants