-
Notifications
You must be signed in to change notification settings - Fork 498
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add fill-extrusion support #1095
Conversation
1. fixed file location issue in generate.dart and bug in generate nestedTypeDart and nestedTypeSwift 2. add typeCamel to iOS template to support fill-extrusion layer 3. regenerated template files
@mrcrow please fix the formatting (see github actions) |
@mrcrow hope this feature will be done soon |
@felix-ht I didn't see any error description about the failed check, just a error code 1, what's the meaning of that? Any suggestion? |
@mrcrow You need to run formatting for all files listed explicitly in the failed "check ... formatting" step logs. E.g. for Swift you need to format LayerPropertyConverter.swift and MapboxMapController.swift The formatting commands are listed in https://github.com/flutter-mapbox-gl/maps/blob/master/.github/workflows/flutter_ci.yml (for java remove the -n option to actually perform the reformatting, not only a dry run) |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Hi everyone, it seems difficult for me and my partner to accomplish the CI workflow, anyone can help us to upload the code again and go through this checking workflow? I don't want this feature to be delayed any longer |
Will take a look on Monday |
Thanks @felix-ht |
|
closed in favor of #1187 |
buildSourceProperty
(please take a look at this issue)