Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support heatmap layer & fill extrusion layer & update image source #1187

Merged
merged 20 commits into from
Oct 10, 2022
Merged

Support heatmap layer & fill extrusion layer & update image source #1187

merged 20 commits into from
Oct 10, 2022

Conversation

hungtrn75
Copy link
Contributor

@hungtrn75 hungtrn75 commented Sep 30, 2022 •
edited
Loading

@hungtrn75 hungtrn75 mentioned this pull request Sep 30, 2022
Closed
@hungtrn75 hungtrn75 changed the title Support heatmap layer Support heatmap layer & fill extrusion layer Sep 30, 2022
felix-ht
felix-ht reviewed Sep 30, 2022
View reviewed changes
scripts/lib/generate.dart Outdated Show resolved Hide resolved
@hungtrn75 hungtrn75 had a problem deploying to ANDROID_CI_DOWNLOADS_TOKEN September 30, 2022 11:42 Failure
@hungtrn75 hungtrn75 had a problem deploying to ANDROID_CI_DOWNLOADS_TOKEN September 30, 2022 11:43 Failure
felix-ht
felix-ht reviewed Sep 30, 2022
View reviewed changes
scripts/pubspec.yaml Outdated Show resolved Hide resolved
felix-ht
felix-ht reviewed Sep 30, 2022
View reviewed changes
scripts/lib/generate.dart Show resolved Hide resolved
scripts/lib/generate.dart Show resolved Hide resolved
@hungtrn75 hungtrn75 had a problem deploying to ANDROID_CI_DOWNLOADS_TOKEN October 1, 2022 09:35 Failure
@hungtrn75 hungtrn75 had a problem deploying to ANDROID_CI_DOWNLOADS_TOKEN October 1, 2022 09:35 Failure
@hungtrn75 hungtrn75 changed the title Support heatmap layer & fill extrusion layer Support heatmap layer & fill extrusion layer & update image source Oct 3, 2022
@felix-ht
Copy link
Collaborator

felix-ht commented Oct 5, 2022

thanks for doing this but if you want to get this merged please stop adding new features.

Its great that you do so but please to it in another branch. This is why it generally is a bad idea to create a PR from your default branch (master/main)

@hungtrn75
Copy link
Contributor Author

thanks for doing this but if you want to get this merged please stop adding new features.

Its great that you do so but please to it in another branch. This is why it generally is a bad idea to create a PR from your default branch (master/main)

Ok. I will add new features in another branch

@hungtrn75 hungtrn75 had a problem deploying to ANDROID_CI_DOWNLOADS_TOKEN October 10, 2022 09:04 Failure
@hungtrn75 hungtrn75 had a problem deploying to ANDROID_CI_DOWNLOADS_TOKEN October 10, 2022 09:04 Failure
felix-ht
felix-ht approved these changes Oct 10, 2022
View reviewed changes
Copy link
Collaborator

@felix-ht felix-ht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@felix-ht felix-ht temporarily deployed to ANDROID_CI_DOWNLOADS_TOKEN October 10, 2022 09:13 Inactive
@felix-ht felix-ht temporarily deployed to ANDROID_CI_DOWNLOADS_TOKEN October 10, 2022 09:13 Inactive
@felix-ht felix-ht mentioned this pull request Oct 10, 2022
Closed
@felix-ht felix-ht merged commit 83a5cda into flutter-mapbox-gl:master Oct 10, 2022
srmncnk pushed a commit to srmncnk/maps that referenced this pull request Oct 26, 2022
@hungtrn75
Support heatmap layer & fill extrusion layer & update image source (f…
67a356b 
…lutter-mapbox-gl#1187)

* fix: can not find path when run script in macOS & nested dart types errors

* fix: can not sync project

* feat: support heatmap layer

* feat: support heatmap layer

* feat: support heatmap layer

* feat: support heatmap layer

* local pbxproj

* fix: error when not await future setSymboAllowOverlap in example

* fix: error when not await future setSymboAllowOverlap in example

* add fill extrusion example

* fix: error generate code swift template with snake case

* migration: edit swift template & add ios rename props

* feat: support fill extrusion layer

* ci: run jobs

* docs: support fill extrusion layer

* docs: support fill extrusion layer

* refactor codegen

* add update image source example

* feat: update image for image source

* remove xcode teamid
srmncnk pushed a commit to srmncnk/maps that referenced this pull request Oct 26, 2022
@hungtrn75
Support heatmap layer & fill extrusion layer & update image source (f…
4a5cda1 
…lutter-mapbox-gl#1187)

* fix: can not find path when run script in macOS & nested dart types errors

* fix: can not sync project

* feat: support heatmap layer

* feat: support heatmap layer

* feat: support heatmap layer

* feat: support heatmap layer

* local pbxproj

* fix: error when not await future setSymboAllowOverlap in example

* fix: error when not await future setSymboAllowOverlap in example

* add fill extrusion example

* fix: error generate code swift template with snake case

* migration: edit swift template & add ios rename props

* feat: support fill extrusion layer

* ci: run jobs

* docs: support fill extrusion layer

* docs: support fill extrusion layer

* refactor codegen

* add update image source example

* feat: update image for image source

* remove xcode teamid
srmncnk pushed a commit to srmncnk/maps that referenced this pull request Oct 26, 2022
@hungtrn75
Support heatmap layer & fill extrusion layer & update image source (f…
2b3e796 
…lutter-mapbox-gl#1187)

* fix: can not find path when run script in macOS & nested dart types errors

* fix: can not sync project

* feat: support heatmap layer

* feat: support heatmap layer

* feat: support heatmap layer

* feat: support heatmap layer

* local pbxproj

* fix: error when not await future setSymboAllowOverlap in example

* fix: error when not await future setSymboAllowOverlap in example

* add fill extrusion example

* fix: error generate code swift template with snake case

* migration: edit swift template & add ios rename props

* feat: support fill extrusion layer

* ci: run jobs

* docs: support fill extrusion layer

* docs: support fill extrusion layer

* refactor codegen

* add update image source example

* feat: update image for image source

* remove xcode teamid
FreeGrow added a commit to FreeGrow/maps that referenced this pull request Sep 21, 2023
@FreeGrow
Revert "Support heatmap layer & fill extrusion layer & update image s…
c0e7dc6 
…ource (flutter-mapbox-gl#1187)"

This reverts commit 83a5cda.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felix-ht felix-ht felix-ht approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hungtrn75 @felix-ht