Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[google_maps_flutter] Use completer to get map id #464

Merged
merged 1 commit into from
Oct 20, 2022
Merged

[google_maps_flutter] Use completer to get map id #464

merged 1 commit into from
Oct 20, 2022

Conversation

bbrto21
Copy link
Contributor

@bbrto21 bbrto21 commented Oct 13, 2022

  • Map generation callback is an asynchronous call, so a completeer is required.
  • This patch fixes test failures that occur on the device while testing.

Signed-off-by: Boram Bae boram21.bae@samsung.com

@bbrto21
[google_maps_flutter] Use completer to get map id
6a602e1 
* Map generation callback is an asynchronous call, so a completeer is required.
* This patch fixes test failures that occur on the device while testing.

Signed-off-by: Boram Bae <boram21.bae@samsung.com>
bwikbs
bwikbs approved these changes Oct 13, 2022
View reviewed changes
Copy link
Member

@bwikbs bwikbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@swift-kim
Copy link
Member

Why don't you update the test code (and etc.) to the latest?

https://github.com/flutter/plugins/blob/main/packages/google_maps_flutter/google_maps_flutter/example/integration_test/google_maps_test.dart

@bbrto21
Copy link
Contributor Author

bbrto21 commented Oct 13, 2022

@swift-kim
Of course I considered it first, but I couldn't get the latest tests as is. because some extra work is needed to make the test successful and I don't have much time right now. I'll keep tracking this issue and do it later.

@bbrto21 bbrto21 mentioned this pull request Oct 13, 2022
Open
@bbrto21 bbrto21 merged commit a2c1741 into flutter-tizen:master Oct 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bwikbs bwikbs bwikbs approved these changes

@swift-kim swift-kim swift-kim approved these changes

Assignees
No one assigned
Labels
p: google_maps_flutter
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bbrto21 @swift-kim @bwikbs