Updated Dart autoroller scripts #234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Respect TERM=dumb (don't print colors) - Kill child processes properly if the roller is stopped - Unbuffer output for better logging - Allow for skipping the creation of a pull request - Other mysterious features and bug fixes!
a-siva
approved these changes
Apr 16, 2019
| @@ -272,7 +293,9 @@ def wait_for_status(commit): | |||
| status = commit.get_combined_status().state | |||
| if status == GITHUB_STATUS_SUCCESS: | |||
| break | |||
| elif status == GITHUB_STATUS_FAILURE: | |||
| # If the only the engine builders are red, keep trying. | |||
cbracken
reviewed
Apr 22, 2019
| @@ -1,4 +1,4 @@ | |||
| #!/usr/bin/env python | |||
| #!/usr/bin/python -u | |||
There was a problem hiding this comment.
Why hardcode the path? Not that we build on FreeBSD, and yes this is super specific to our infra, but this would break people whose python is at e.g. /usr/local/bin/python
There was a problem hiding this comment.
I think the existing string was breaking things with the '-u' option, but it seems fine now... I'll change it back.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated Dart autoroller scripts to: