Use CIPD Windows SDK to generate WinRT headers #448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather than relying on the Windows SDK that happens to be on the host machine, we now pull down the Windows SDK from CIPD into third_party/windows_sdk and use it directly. cppwinrt relies on a registry entry to determine the SDK location and doesn't currently support a mechanism for specifying this location explicitly via an argument. Instead, we do what cppwinrt itself does and parse out the Platform.XML file to determine the set of .winmd files to take as input, then pass them to the tool directly.
cbracken
force-pushed
the
use-cipd-windows-sdk
branch
from
8aad457
to
9247bf1
Compare
cbracken
added a commit
to cbracken/flutter_engine
that referenced
this pull request
May 7, 2021
We now build against a specific Windows SDK rather than whatever happens to be installed on the host machine. This also rolls the buildroot to include change flutter/buildroot#448, which generates the WinRT headers from the CIPD Windows SDK.
cbracken
added a commit
to cbracken/flutter_engine
that referenced
this pull request
May 7, 2021
We now build against a specific Windows SDK rather than whatever happens to be installed on the host machine. This also rolls the buildroot to include change flutter/buildroot#448, which generates the WinRT headers from the CIPD Windows SDK.
cbracken
added a commit
to cbracken/flutter_engine
that referenced
this pull request
May 7, 2021
We now build against a specific Windows SDK rather than whatever happens to be installed on the host machine. This also rolls the buildroot to include change flutter/buildroot#448, which generates the WinRT headers from the CIPD Windows SDK. This also re-enables the UWP builder.
9 tasks
cbracken
added a commit
to cbracken/buildroot
that referenced
this pull request
May 7, 2021
Canonicalizes input paths we pass to cppwinrt to avoid failures to open files. Followup to flutter#448
cbracken
added a commit
that referenced
this pull request
May 7, 2021
Canonicalizes input paths we pass to cppwinrt to avoid failures to open files. Followup to #448
cbracken
added a commit
to cbracken/flutter_engine
that referenced
this pull request
May 7, 2021
We now build against a specific Windows SDK rather than whatever happens to be installed on the host machine. This also rolls the buildroot to include change flutter/buildroot#448, which generates the WinRT headers from the CIPD Windows SDK. This also re-enables the UWP builder.
cbracken
added a commit
to cbracken/flutter_engine
that referenced
this pull request
May 7, 2021
We now build against a specific Windows SDK rather than whatever happens to be installed on the host machine. This also rolls the buildroot to include change flutter/buildroot#448, which generates the WinRT headers from the CIPD Windows SDK. This also rolls an updated version of cppwinrt that includes supports for long paths. This also re-enables the UWP builder.
cbracken
added a commit
to cbracken/flutter_engine
that referenced
this pull request
May 7, 2021
We now build against a specific Windows SDK rather than whatever happens to be installed on the host machine. This also rolls the buildroot to include change flutter/buildroot#448, which generates the WinRT headers from the CIPD Windows SDK. This also rolls an updated version of cppwinrt that includes supports for long paths. This also re-enables the UWP builder.
This was referenced May 7, 2021
christopherfujino
added a commit
to christopherfujino/engine
that referenced
this pull request
May 7, 2021
cbracken
added a commit
to cbracken/flutter_engine
that referenced
this pull request
May 7, 2021
We now build against a specific Windows SDK rather than whatever happens to be installed on the host machine. This also rolls the buildroot to include change flutter/buildroot#448, which generates the WinRT headers from the CIPD Windows SDK. This also rolls an updated version of cppwinrt that includes supports for long paths. This also re-enables the UWP builder.
cbracken
added a commit
to cbracken/flutter_engine
that referenced
this pull request
May 7, 2021
We now build against a specific Windows SDK rather than whatever happens to be installed on the host machine. This also rolls the buildroot to include change flutter/buildroot#448, which generates the WinRT headers from the CIPD Windows SDK. This also rolls an updated version of cppwinrt that includes supports for long paths. This also re-enables the UWP builder.
cbracken
added a commit
to cbracken/flutter_engine
that referenced
this pull request
May 7, 2021
We now build against a specific Windows SDK rather than whatever happens to be installed on the host machine. This also rolls the buildroot to include change flutter/buildroot#448, which generates the WinRT headers from the CIPD Windows SDK. This also rolls an updated version of cppwinrt that includes supports for long paths. This also re-enables the UWP builder.
cbracken
added a commit
to cbracken/flutter_engine
that referenced
this pull request
May 7, 2021
We now build against a specific Windows SDK rather than whatever happens to be installed on the host machine. This also rolls the buildroot to include change flutter/buildroot#448, which generates the WinRT headers from the CIPD Windows SDK. This also rolls an updated version of cppwinrt that includes supports for long paths. This also re-enables the UWP builder.
cbracken
added a commit
to flutter/engine
that referenced
this pull request
May 8, 2021
We now build against a specific Windows SDK rather than whatever happens to be installed on the host machine. This also rolls the buildroot to include change flutter/buildroot#448, which generates the WinRT headers from the CIPD Windows SDK. This also rolls an updated version of cppwinrt that includes supports for long paths. This also re-enables the UWP builder.
naudzghebre
pushed a commit
to naudzghebre/engine
that referenced
this pull request
May 21, 2021
We now build against a specific Windows SDK rather than whatever happens to be installed on the host machine. This also rolls the buildroot to include change flutter/buildroot#448, which generates the WinRT headers from the CIPD Windows SDK. This also rolls an updated version of cppwinrt that includes supports for long paths. This also re-enables the UWP builder.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than relying on the Windows SDK that happens to be on the host
machine, we now pull down the Windows SDK from CIPD into
third_party/windows_sdk and use it directly.
cppwinrt relies on a registry entry to determine the SDK location and
doesn't currently support a mechanism for specifying this location
explicitly via an argument. Instead, we do what cppwinrt itself does and
parse out the Platform.XML file to determine the set of .winmd files to
take as input, then pass them to the tool directly.
Related: flutter/flutter#81994