Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the sysroot paths relative to the build dir #757

Merged
merged 1 commit into from
Aug 29, 2023

Conversation

zanderso
Copy link
Member

This will hopefully fix an issue with RBE.

@zanderso zanderso changed the title Make the Android NDK sysroot path relative to the build dir Make the sysroot paths relative to the build dir Aug 29, 2023
Copy link

@keyonghan keyonghan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zanderso zanderso merged commit 5b5e954 into flutter:master Aug 29, 2023
2 checks passed
@zanderso zanderso deleted the fix-android-buildroot-path branch August 29, 2023 22:02
zanderso added a commit to flutter/engine that referenced this pull request Aug 29, 2023
To pick up flutter/buildroot#757, which makes some sysroot paths relative.
auto-submit bot pushed a commit to flutter/engine that referenced this pull request Aug 29, 2023
To pick up flutter/buildroot#757, which makes some sysroot paths relative.
gaaclarke pushed a commit to gaaclarke/engine that referenced this pull request Aug 30, 2023
To pick up flutter/buildroot#757, which makes some sysroot paths relative.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants