Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrating Engine targets from Goma to Reclient #132701

Open
3 of 4 tasks
keyonghan opened this issue Aug 16, 2023 · 8 comments
Open
3 of 4 tasks

Migrating Engine targets from Goma to Reclient #132701

keyonghan opened this issue Aug 16, 2023 · 8 comments
Assignees
@keyonghan
Labels
P1 High-priority issues at the top of the work list team-infra Owned by Infrastructure team triaged-infra Triaged by Infrastructure team

Comments

@keyonghan
Copy link
Contributor

keyonghan commented Aug 16, 2023 •
edited

This tracks the status of Goma to Reclient migration.

Context: Goma will be deprecated EOY, and we need to switch over to Reclient.

Action items:
@keyonghan keyonghan added the team-infra Owned by Infrastructure team label Aug 16, 2023
@ricardoamador ricardoamador added P1 High-priority issues at the top of the work list triaged-infra Triaged by Infrastructure team labels Aug 23, 2023
@keyonghan keyonghan mentioned this issue Aug 29, 2023
Closed
@keyonghan keyonghan self-assigned this Aug 29, 2023
This was referenced Sep 13, 2023
Merged
Merged
auto-submit bot pushed a commit to flutter/engine that referenced this issue Sep 14, 2023
@keyonghan
Switch goma to reclient fro standalone targets (#45804)
5512613 
Part of flutter/flutter#132701.
auto-submit bot pushed a commit to flutter/engine that referenced this issue Sep 14, 2023
@keyonghan
Switch linux_android_debug_engine from goma to reclient (#45345)
112342e 
Part of flutter/flutter#132701.
This was referenced Sep 15, 2023
Merged
Merged
Merged
auto-submit bot pushed a commit to flutter/engine that referenced this issue Sep 25, 2023
@keyonghan
Switch goma to reclient for Linux host engine targets (#45884)
1ae3d20 
Part of flutter/flutter#132701
auto-submit bot pushed a commit to flutter/engine that referenced this issue Sep 25, 2023
@keyonghan
Switch goma to reclient for Linux fuchsia/unopt/android_aot (#45899)
d55994d 
Part of flutter/flutter#132701
auto-submit bot pushed a commit to flutter/engine that referenced this issue Sep 25, 2023
@keyonghan
Switch goma to reclient for Linux clang_tidy targets (#45898)
0407495 
Part of flutter/flutter#132701
@auto-submit auto-submit bot mentioned this issue Sep 25, 2023
Merged
auto-submit bot added a commit to flutter/engine that referenced this issue Sep 25, 2023
@auto-submit
Reverts "Switch goma to reclient for Linux clang_tidy targets" (#46267)
3f60657 
Reverts #45898
Initiated by: ricardoamador
This change reverts the following previous change:
Part of flutter/flutter#132701
@keyonghan
Copy link
Contributor Author

flutter/engine#46272 to restore targets that affect framework, waiting for 3.16 branch.

harryterkelsen pushed a commit to flutter/engine that referenced this issue Oct 23, 2023
@keyonghan @harryterkelsen
Switch goma to reclient fro standalone targets (#45804)
427e0d1 
Part of flutter/flutter#132701.
harryterkelsen pushed a commit to flutter/engine that referenced this issue Oct 23, 2023
@keyonghan @harryterkelsen
Switch linux_android_debug_engine from goma to reclient (#45345)
aba0a3b 
Part of flutter/flutter#132701.
harryterkelsen pushed a commit to flutter/engine that referenced this issue Oct 23, 2023
@keyonghan @harryterkelsen
Switch goma to reclient for Linux host engine targets (#45884)
bbcc54c 
Part of flutter/flutter#132701
harryterkelsen pushed a commit to flutter/engine that referenced this issue Oct 23, 2023
@keyonghan @harryterkelsen
Switch goma to reclient for Linux fuchsia/unopt/android_aot (#45899)
da6c2f0 
Part of flutter/flutter#132701
harryterkelsen pushed a commit to flutter/engine that referenced this issue Oct 23, 2023
@keyonghan @harryterkelsen
Switch goma to reclient for Linux clang_tidy targets (#45898)
51a68f4 
Part of flutter/flutter#132701
harryterkelsen pushed a commit to flutter/engine that referenced this issue Oct 23, 2023
@auto-submit @harryterkelsen
Reverts "Switch goma to reclient for Linux clang_tidy targets" (#46267)
f15c258 
Reverts #45898
Initiated by: ricardoamador
This change reverts the following previous change:
Part of flutter/flutter#132701
@philwo
Copy link

philwo commented Nov 29, 2023

Hi folks, could you please share an update on the current progress of migrating from Goma to RBE? How much is still left to do?

@keyonghan
Copy link
Contributor Author

Flutter team is still working on the migration, but we have a couple of blockers from our side. #136570 is one example.

Also we need to collect some baseline data before moving forward. Still targeting in Q4, but we cannot guarantee.

@philwo
Copy link

philwo commented Nov 30, 2023

Thank you, that's very helpful!

@dnfield
Copy link
Contributor

dnfield commented Dec 7, 2023

It would be nice to target the clang-tidy targets sooner than later. They're currently very slow and should be acceptably fast if we run them via reclient.

@matanlurey matanlurey mentioned this issue Dec 7, 2023
Closed
1 task
@atetubou
Copy link

Hi, what is the current status of this issue? Did you stop using goma?

@keyonghan
Copy link
Contributor Author

keyonghan commented Apr 11, 2024 •
edited

Hi, what is the current status of this issue? Did you stop using goma?

We are almost done! Just shared a tracking sheet named Engine Reclient migration status with you. Now we have only a single target Mac impeller-cmake-example is using goma, but it has been failing all the time. /cc @zanderso may know the plan ahead for this test.

@zanderso
Copy link
Member

We're still using goma in the build that @keyonghan mentions, and migrating from goma to reclient for local developer workflows is blocked on a small amount of documentation and tooling work. I suspect that there are still a few weeks of calendar time remaining before we can start deleting goma support from the tree.

I would also really like to move our clang-tidy usage to reclient, but that is blocked on b/326591374 and any issues that it is potentially masking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@keyonghan keyonghan

Labels
P1 High-priority issues at the top of the work list team-infra Owned by Infrastructure team triaged-infra Triaged by Infrastructure team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@philwo @atetubou @zanderso @dnfield @ricardoamador @keyonghan