[scheduler] Increment task attempts and reset status on reruns (#1656)

flutter · Mar 10, 2022 · 4bd47fb · 4bd47fb
1 parent a826a73
commit 4bd47fb
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 0 deletions.
diff --git a/app_dart/lib/src/service/luci_build_service.dart b/app_dart/lib/src/service/luci_build_service.dart
@@ -545,6 +545,11 @@ class LuciBuildService {
       ],
     );
     await pubsub.publish('scheduler-requests', request);
+
+    task.attempts = (task.attempts ?? 0) + 1;
+    task.status = Task.statusNew;
+    await datastore.insert(<Task>[task]);
+
     return true;
   }
 

diff --git a/app_dart/test/service/luci_build_service_test.dart b/app_dart/test/service/luci_build_service_test.dart
@@ -538,6 +538,8 @@ void main() {
         buildNumber: 1,
       );
       final Target target = generateTarget(1);
+      expect(task.attempts, 1);
+      expect(task.status, Task.statusFailed);
       final bool rerunFlag = await service.checkRerunBuilder(
         commit: totCommit,
         task: task,
@@ -553,6 +555,8 @@ void main() {
       }
       expect(scheduleBuildRequest.gitilesCommit?.project, 'mirrors/engine');
       expect(rerunFlag, isTrue);
+      expect(task.attempts, 2);
+      expect(task.status, Task.statusNew);
     });
 
     test('Rerun a test failed builder', () async {