Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove cocoon mirroring from main to master. #1410

Merged
merged 1 commit into from
Oct 21, 2021
Merged

Remove cocoon mirroring from main to master. #1410

merged 1 commit into from
Oct 21, 2021

Conversation

godofredoc
Copy link
Contributor

Everything in this repository has been migrated to main and we are ready
to remove the master branch.

Bug: flutter/flutter#90476

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read the Flutter Style Guide recently, and have followed its advice.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@godofredoc
Remove cocoon mirroring from main to master.
355e27e 
Everything in this repository has been migrated to main and we are ready
to remove the master branch.

Bug: flutter/flutter#90476
@google-cla google-cla bot added the cla: yes label Oct 21, 2021
@godofredoc godofredoc added the waiting for tree to go green Merge PR when tree becomes green via fluttergithubbot label Oct 21, 2021
@fluttergithubbot
Copy link

This pull request is not suitable for automatic merging in its current state.

  • Please get at least one approved review before re-applying this label. Reviewers: If you left a comment approving, please use the "approve" review action instead.

@fluttergithubbot fluttergithubbot removed the waiting for tree to go green Merge PR when tree becomes green via fluttergithubbot label Oct 21, 2021
keyonghan
keyonghan approved these changes Oct 21, 2021
View reviewed changes
Copy link
Contributor

@keyonghan keyonghan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@godofredoc godofredoc added the waiting for tree to go green Merge PR when tree becomes green via fluttergithubbot label Oct 21, 2021
@fluttergithubbot fluttergithubbot merged commit 0821feb into flutter:main Oct 21, 2021
CaseyHillers added a commit that referenced this pull request Nov 10, 2021
@CaseyHillers
Revert "Remove cocoon mirroring from main to master. (#1410)"
ad19d64 
This reverts commit 0821feb.
@CaseyHillers CaseyHillers mentioned this pull request Nov 10, 2021
Merged
godofredoc pushed a commit that referenced this pull request Nov 10, 2021
Revert "Remove cocoon mirroring from main to master. (#1410)" (#1451)
ac008a1 
This reverts commit 0821feb.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keyonghan keyonghan keyonghan approved these changes

@CaseyHillers CaseyHillers Awaiting requested review from CaseyHillers

@yusuf-goog yusuf-goog Awaiting requested review from yusuf-goog

Assignees
No one assigned
Labels
waiting for tree to go green Merge PR when tree becomes green via fluttergithubbot
Projects
None yet
Milestone
No milestone
3 participants
@godofredoc @fluttergithubbot @keyonghan