Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Remove cocoon mirroring from main to master." #1451

Merged
merged 1 commit into from
Nov 10, 2021
Merged

Revert "Remove cocoon mirroring from main to master." #1451

merged 1 commit into from
Nov 10, 2021

Conversation

CaseyHillers
Copy link
Contributor

Reverts #1410

@google-cla google-cla bot added the cla: yes label Nov 10, 2021
@CaseyHillers
Copy link
Contributor Author

This requires re-creating the master branch (I lack admin privileges)

@CaseyHillers CaseyHillers added the waiting for tree to go green Merge PR when tree becomes green via fluttergithubbot label Nov 10, 2021
@fluttergithubbot
Copy link

This pull request is not suitable for automatic merging in its current state.

  • This commit has empty status or empty checks. Please check the Google CLA status is present and Flutter Dashboard application has multiple checks.

@fluttergithubbot fluttergithubbot removed the waiting for tree to go green Merge PR when tree becomes green via fluttergithubbot label Nov 10, 2021
@godofredoc
Copy link
Contributor

I believe we can abandon this PR.

@CaseyHillers
Copy link
Contributor Author

I believe we can abandon this PR.

Were you able to get the sync working in the repo settings?

@godofredoc
Copy link
Contributor

godofredoc commented Nov 10, 2021 via email

@CaseyHillers
Copy link
Contributor Author

What mechanism would ensure master is staying in sync with main?

@godofredoc
Copy link
Contributor

What mechanism would ensure master is staying in sync with main?

aaah, I thought you were reverting adding the mirroring because it was landed before the master branch was in sync.

@godofredoc godofredoc merged commit ac008a1 into main Nov 10, 2021
@godofredoc godofredoc deleted the revert-1410-remove_cocoon_mirroring branch November 10, 2021 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@godofredoc godofredoc godofredoc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@CaseyHillers @fluttergithubbot @godofredoc