-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use search API to find matching PR for ci.yaml validation reruns #2402
Conversation
@@ -40,6 +40,27 @@ class GithubChecksUtil { | |||
); | |||
} | |||
|
|||
/// Finds all check suites that are associated with a given git [ref]. | |||
Future<Stream<github.CheckSuite>> listCheckSuitesForRef( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests for this method?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you suggest how I should test this? I added a test for searchIssuesAndPRs
to validate that it encodes the query properly, but for listCheckSuitesForRef
and getPullRequest
I can't think of anything since they just forward the call unconditionally.
Setting to draft while I fix the scheduler test. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we manually release a version to test this change?
I was able to deploy it and successfully perform a ci.yaml validation rerun on flutter/flutter#118690. 😄 The only hitch is that previously failed webhook events which requested to rerun ci.yaml keep being retried. The problem is that the PRs associated are already closed or have had a new commit, which invalidates the check suite. This causes the event processing to fail and is causing looping retries. I think we might have to drain those events. |
You can take a look at the subscription, it may already be configured to auto drop messages older than 24h |
According to flutter/flutter#100081, this should fix ci.yaml validation errors.
Pre-launch Checklist
///
).