Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated to remove dependency override for web_socket_channel #2405

Merged
merged 1 commit into from
Jan 19, 2023

Conversation

ricardoamador
Copy link
Contributor

@ricardoamador ricardoamador commented Jan 19, 2023

The web_socket_channel dependency has been locked to 2.2.0 in the newest graphql package. We do not need to override it here.

List which issues are fixed by this PR. You must list at least one issue.
Fixes flutter/flutter#118352

If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read the Flutter Style Guide recently, and have followed its advice.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Copy link
Contributor

@nehalvpatel nehalvpatel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ricardoamador ricardoamador added the autosubmit Merge PR when tree becomes green via auto submit App. label Jan 19, 2023
@auto-submit auto-submit bot merged commit fa8840f into flutter:main Jan 19, 2023
@ricardoamador ricardoamador deleted the remove_dependency_exclusion branch January 30, 2023 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Graphql transitive dependency web_socket_channel 2.3.0 causes builds to fail
2 participants