Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Offline analysis for heap snapshots #5606

Open
polina-c opened this issue Apr 3, 2023 · 4 comments
Open

Offline analysis for heap snapshots #5606

polina-c opened this issue Apr 3, 2023 · 4 comments
Assignees
@polina-c
Labels
memory page > diff P1 high priority issues at the top of the work list, actively being worked on.

Comments

@polina-c
Copy link
Contributor

polina-c commented Apr 3, 2023 •
edited
Loading

We want user to be able to take heap snapshots in release mode and analyze them later in DevTools > Memory > Diff

How to take snapshot in release mode: https://github.com/dart-lang/sdk/blob/main/runtime/tools/heapsnapshot/README.md
@polina-c polina-c self-assigned this Apr 3, 2023
@polina-c
Copy link
Contributor Author

polina-c commented Apr 3, 2023 •
edited
Loading

@polina-c polina-c mentioned this issue May 3, 2023
Closed
@polina-c
Copy link
Contributor Author

polina-c commented May 4, 2023

Screen.Recording.2023-05-03.at.8.24.11.PM.mov

@polina-c
Copy link
Contributor Author

polina-c commented May 7, 2023

Error handling:
Screenshot 2023-05-06 at 8 56 53 PM

copybara-service bot pushed a commit to dart-lang/sdk that referenced this issue May 16, 2023
@polina-c
Add auto-snapshotting and analytics for memory usage.
5f1e7ad 
See video linked to issue: flutter/devtools#5606

Change-Id: I9f22031871e30bc7160e2c49b0423fb64df62223
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/300862
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Jacob Richman <jacobr@google.com>
copybara-service bot pushed a commit to dart-lang/sdk that referenced this issue May 17, 2023
@dcharkes
Revert "Add auto-snapshotting and analytics for memory usage."
dba0758 
This reverts commit 5f1e7ad.

Reason for revert: bots are failing

Original change's description:
> Add auto-snapshotting and analytics for memory usage.
>
> See video linked to issue: flutter/devtools#5606
>
> Change-Id: I9f22031871e30bc7160e2c49b0423fb64df62223
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/300862
> Reviewed-by: Samuel Rawlins <srawlins@google.com>
> Reviewed-by: Jacob Richman <jacobr@google.com>

Change-Id: I54cb3943230ab1229cc8b2c9df40e9c71765df19
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/303881
Auto-Submit: Polina Cherkasova <polinach@google.com>
Reviewed-by: Polina Cherkasova <polinach@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Daco Harkes <dacoharkes@google.com>
@whesse whesse mentioned this issue May 23, 2023
Merged
7 tasks
@whesse
Copy link
Contributor

whesse commented May 23, 2023

The change was relanded in https://dart-review.googlesource.com/c/sdk/+/304212 but the leak_tracked package was not added to Flutter engine DEPS before adding dependencies on it. This causes failures on monorepo builds and when rolling Dart into engine. Fixed by flutter/engine#42241

auto-submit bot pushed a commit to flutter/engine that referenced this issue May 23, 2023
@whesse
Add leak_tracker package from Dart DEPS to DEPS (#42241)
431ed51 
The package leak_tracker was added to Dart DEPS, and analysis_server now depends on it.
This fixes a breakage when rolling Dart into Flutter engine.

Bug: flutter/devtools#5606
@kenzieschmoll kenzieschmoll added P1 high priority issues at the top of the work list, actively being worked on. and removed P3 labels Jul 5, 2023
@kenzieschmoll kenzieschmoll mentioned this issue Dec 14, 2023
Open
16 tasks
@polina-c polina-c mentioned this issue Dec 15, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@polina-c polina-c

Labels
memory page > diff P1 high priority issues at the top of the work list, actively being worked on.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@whesse @polina-c @kenzieschmoll