Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flutter inspector settings auto-detects the wrong project directory #6853

Open
elliette opened this issue Nov 29, 2023 · 1 comment
Open

Flutter inspector settings auto-detects the wrong project directory #6853

elliette opened this issue Nov 29, 2023 · 1 comment

Comments

@elliette
Copy link
Member

elliette commented Nov 29, 2023 •
edited

This is really two issues that an internal customer is hitting:

1. For large apps, auto-detection of the package directory fails, so there is an infinite spinner next to the package directory settings (because of this the widget tree is empty)
2. If you then try to add a package directory manually, that fails (I'm guessing because we are stuck trying to detect the package directory)

package loading
@elliette
Copy link
Member Author

I think I was experience that because my server had gone dormant. When I restarted the application server and opened DevTools, it did auto-detect a project directory, but erroneously auto-detected the Flutter project.

@elliette elliette changed the title Can't add a package directory if auto-page directory loading fails Flutter inspector settings auto-detects the wrong project directory Nov 29, 2023
@elliette elliette mentioned this issue Nov 30, 2023
Merged
auto-submit bot pushed a commit that referenced this issue Nov 30, 2023
@elliette
Fix project directory inference for inspector panel (#6857)
b28a431 
Fixes #6841, #6853

Instead of using the top level widget in the widget tree to determine the project directory, we instead use the main isolate's root library. 

For google3, we also have extra logic to strip out everything before `/google3`, and to only use top-level directory after `google3` directory (or the top-level directory after `third_party`)
elliette added a commit that referenced this issue Dec 1, 2023
@elliette
Fix project directory inference for inspector panel (#6857)
bdfdeab 
Fixes #6841, #6853

Instead of using the top level widget in the widget tree to determine the project directory, we instead use the main isolate's root library.

For google3, we also have extra logic to strip out everything before `/google3`, and to only use top-level directory after `google3` directory (or the top-level directory after `third_party`)
derekxu16 pushed a commit to derekxu16/devtools that referenced this issue Dec 14, 2023
@elliette @derekxu16
Fix project directory inference for inspector panel (flutter#6857)
80d72f5 
Fixes flutter#6841, flutter#6853

Instead of using the top level widget in the widget tree to determine the project directory, we instead use the main isolate's root library.

For google3, we also have extra logic to strip out everything before `/google3`, and to only use top-level directory after `google3` directory (or the top-level directory after `third_party`)
derekxu16 pushed a commit to derekxu16/devtools that referenced this issue Dec 14, 2023
@elliette @derekxu16
Fix project directory inference for inspector panel (flutter#6857)
ab1937a 
Fixes flutter#6841, flutter#6853

Instead of using the top level widget in the widget tree to determine the project directory, we instead use the main isolate's root library.

For google3, we also have extra logic to strip out everything before `/google3`, and to only use top-level directory after `google3` directory (or the top-level directory after `third_party`)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@elliette