Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update goldens #1266

Merged
merged 1 commit into from Oct 29, 2019
Merged

update goldens #1266

merged 1 commit into from Oct 29, 2019

Conversation

DaveShuckerow
Copy link
Contributor

No description provided.

@DaveShuckerow
Copy link
Contributor Author

The only remaining test failure is #1267. Merging.

@DaveShuckerow DaveShuckerow merged commit 4e45eff into flutter:master Oct 29, 2019
@DaveShuckerow DaveShuckerow deleted the update-goldens branch October 29, 2019 22:10
@DaveShuckerow DaveShuckerow mentioned this pull request Oct 29, 2019
Merged
2 tasks
@jacob314
Copy link
Contributor

This improvement in the goldens is due to the error CL @albertusangga just landed in Flutter. :)

@albertusdev
Copy link
Contributor

this is awesome omg

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kenzieschmoll kenzieschmoll kenzieschmoll approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@DaveShuckerow @jacob314 @albertusdev @kenzieschmoll