Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop disposing Notifications and Controllers from import_export. #1640

Merged
merged 1 commit into from Feb 17, 2020

Conversation

kenzieschmoll
Copy link
Member

Fixes #1637.

Copy link
Contributor

@jacob314 jacob314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kenzieschmoll kenzieschmoll merged commit f585a85 into flutter:master Feb 17, 2020
@kenzieschmoll kenzieschmoll deleted the importExportFix branch February 17, 2020 20:44
@terrylucas
Copy link
Contributor

Kenzie,

You'll want to either remove my TODO and commented out dispose or enable the notifications?.dispose() in config_specific/flutter/drag_drop.dart

@OverRide
void dispose() {
// TODO(Kenzie): Disabled see issue #1637.
// notifications?.dispose();
super.dispose();
}

@kenzieschmoll
Copy link
Member Author

kenzieschmoll commented Feb 18, 2020

I noticed that after I landed this CL. I have a pending import PR that includes this change.

@terrylucas
Copy link
Contributor

terrylucas commented Feb 18, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Any Flutter integration test fails with import_export added.
3 participants