Add support for serving a custom DevTools build #2748
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Dart SDK will use a pinned version pre-built version of DevTools. This means that DDS requires a way to provide a path to the pinned build to devtools_server in order to correctly serve the application.
|
will there be possible version skew between the devtools_server and devtools_app in this mode. That should be fine but we should document that you cannot depend on the app and server to be the exact same version anymore if that is the plan. |
|
|
Nope! The SDK will pull in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Dart SDK will use a pinned version pre-built version of DevTools. This means that DDS requires a way to provide a path to the pinned build to devtools_server in order to correctly serve the application.