Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for older VMs, filter dialog, and retained. #2752

Merged
merged 14 commits into from Mar 1, 2021
Merged

Add support for older VMs, filter dialog, and retained. #2752

merged 14 commits into from Mar 1, 2021

Conversation

terrylucas
Copy link
Contributor

@terrylucas terrylucas commented Mar 1, 2021 •
edited

  • Added backward support for older VMs (use _setTraceClassAllocation).
  • Fixed filter dialog to use DevToolsDialog and properly support cancel button.

image

  • Remove Retained values until dominator support.

Fixed #2339

@terrylucas terrylucas requested a review from jacob314 March 1, 2021 05:39
kenzieschmoll
kenzieschmoll reviewed Mar 1, 2021
View reviewed changes
packages/devtools_app/lib/src/memory/memory_filter.dart Outdated Show resolved Hide resolved
packages/devtools_app/lib/src/memory/memory_filter.dart Outdated Show resolved Hide resolved
packages/devtools_app/lib/src/memory/memory_filter.dart Outdated Show resolved Hide resolved
packages/devtools_app/lib/src/memory/memory_filter.dart Outdated Show resolved Hide resolved
packages/devtools_app/lib/src/memory/memory_filter.dart Outdated Show resolved Hide resolved
packages/devtools_app/lib/src/memory/memory_filter.dart Outdated Show resolved Hide resolved
packages/devtools_app/lib/src/memory/memory_heap_tree_view.dart Show resolved Hide resolved
packages/devtools_app/lib/src/memory/memory_heap_tree_view.dart Outdated Show resolved Hide resolved
packages/devtools_app/lib/src/vm_service_wrapper.dart Outdated Show resolved Hide resolved
packages/devtools_app/lib/src/vm_service_wrapper.dart Show resolved Hide resolved
kenzieschmoll
kenzieschmoll approved these changes Mar 1, 2021
View reviewed changes
Copy link
Member

@kenzieschmoll kenzieschmoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm_ship_it

@terrylucas terrylucas merged commit dcf9383 into flutter:master Mar 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kenzieschmoll kenzieschmoll kenzieschmoll approved these changes

@jacob314 jacob314 Awaiting requested review from jacob314

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Memory filter state incorrect after clicking cancel
3 participants
@terrylucas @jacob314 @kenzieschmoll