Don't wait on stream listening in DevTools start up #3333
Conversation
…up (flutter#3320)" (flutter#3321)" This reverts commit bb5e4a0.
|
Made some changes from the original in response to #3320 (comment):
|
| @@ -286,7 +273,21 @@ class ServiceConnectionManager { | |||
| ); | |||
| } | |||
| } | |||
| })); | |||
| } | |||
There was a problem hiding this comment.
if we are worried about missing isolate events, what if we only await listening to streams that we are concerned about? perhaps kIsolate and kVM?
There was a problem hiding this comment.
cc @jacob314 for input on this
There was a problem hiding this comment.
Ok thought about this a bit more. If the VM is handling our requests in order we don't need to await any of these as long as we ensure that we send the request over the VM Service for the streams before we preform operations getting the current states of the streams. I would double check that we aren't loading isolate objects before the stream listen code and we should be good.
There was a problem hiding this comment.
I'm not sure if it matters in this case, but there's no guarantee that the VM service will finish processing a request before a more recent request is completed. Obviously this won't be an issue if you're the only client and you're awaiting on each service request, but just something to keep in mind.
There was a problem hiding this comment.
Confirmed that we are triggering the requests for streams before loading any isolate objects
|
|
Follow-up to #3320 (reverted in #3321).