Add timing analytics for debugger page load #3346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacob314
reviewed
Sep 8, 2021
jacob314
reviewed
Sep 8, 2021
jacob314
approved these changes
Sep 8, 2021
kenzieschmoll
changed the title
jacob314
reviewed
Sep 9, 2021
jacob314
reviewed
Sep 9, 2021
jacob314
reviewed
Sep 9, 2021
jacob314
reviewed
Sep 9, 2021
| @@ -9,6 +9,7 @@ import 'package:provider/provider.dart'; | |||
| import 'package:vm_service/vm_service.dart'; | |||
|
|
|||
| import '../analytics/analytics.dart' as ga; | |||
| import '../analytics/constants.dart' as analytics_constants; | |||
There was a problem hiding this comment.
probably not following it elsewhere in devtools but I beleive this should be analyticsConstants or constants not analytics_constants although maybe I'm missing something in the style guide.
There was a problem hiding this comment.
underscores is per the style guide. See https://dart-lang.github.io/linter/lints/library_prefixes.html, which is triggered if you name as analyticsConstants
jacob314
reviewed
Sep 9, 2021
| parsedScript != null && | ||
| !_shownFirstScript) { | ||
| ga.timeEnd(DebuggerScreen.id, analytics_constants.pageReady); | ||
| // TODO(annagrin): mark end of IPL timing for debugger page here. |
There was a problem hiding this comment.
Fyi @annagrin to dispatch an event dwds can listen for as well.
There was a problem hiding this comment.
I am adding ext.dwds.sendEvent service extension to dwds, it will expect an event { 'type': 'DevtoolsReady', 'payload': {} } .
This was referenced Sep 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.