Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cleanup] Moved test helper code from "test/support" to a new "devtools_test" package #3406

Merged
merged 16 commits into from Sep 29, 2021

Conversation

matt-ragonese
Copy link
Contributor

@matt-ragonese matt-ragonese commented Sep 28, 2021

In addition to creating the new devtools_test package and moving test/support code into it, this change also:

  • moves shared mocks/fakes in devtools_app into devtools_test
  • moves the waitFor(...) helper function into devtools_test's utils.dart
  • adds a new devtools_app.dart file that exports src files used outside of devtools_app

@matt-ragonese matt-ragonese marked this pull request as ready for review September 29, 2021 16:44
.gitignore Outdated Show resolved Hide resolved
Copy link
Member

@kenzieschmoll kenzieschmoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kenzieschmoll kenzieschmoll merged commit 8411e87 into flutter:master Sep 29, 2021
matt-ragonese added a commit to matt-ragonese/devtools that referenced this pull request Sep 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants