New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update DevTools release instructions #3428
Update DevTools release instructions #3428
Conversation
tool/README.md
Outdated
|
||
Turn off this advice by setting config variable advice.detachedHead to false | ||
|
||
HEAD is now at 8881a7ca Update release scripts (#3426) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure we can use the shortened hashes (I haven't tried though).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated to use the full hash JIC
tool/README.md
Outdated
given git commit hash, and upload the binary to CIPD. | ||
|
||
```shell | ||
sdk/third_party/devtools/update.sh 8881a7ca |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This command actually pulls down everything you need to build and publish to CIPD, so there's no need to be in a particular branch or to build DevTools before running this script, and it won't nuke any local changes in your DevTools repo. The temporary copy will be deleted once the script is complete.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gotcha. Since this is the last pub release (though we may have one more that gives a note about dart devtools
, I'll remove all the pub related instructions.
tool/README.md
Outdated
the id for the CIPD upload in the previous step). See this | ||
[example CL](https://dart-review.googlesource.com/c/sdk/+/215520). | ||
|
||
Now verify that running `dart devtools` launches the version of DevTools you just released. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You'll need to build the SDK to check this:
$ cd ~/dart-sdk/sdk
$ gclient sync -D
$ ./tools/build.py -mrelease -ax64 create_sdk // create_platform_sdk is faster but doesn't build web tooling
$ out/ReleaseX64/dart-sdk/bin/dart devtools // On OSX replace 'out' with 'xcodebuild'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added.
Updated instructions - PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CIPD + SDK steps LGTM
These instructions reflect the new release process. Instructions relating to pub will be removed for the next release.