Refactors search to have private _SearchField and _AutoCompleteSearchField widgets #3442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
702
to
703
| String newValue, | ||
| int caretPosition, |
There was a problem hiding this comment.
should these be required?
There was a problem hiding this comment.
Ah good catch! Marked them as required, thanks!
kenzieschmoll
approved these changes
Oct 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
buildSearchFieldmethod now returns a private_SearchFieldwidgetbuildAutoCompleteSearchFieldmethods now returns a private_AutoCompleteSearchFieldwidgetbuildSearchFieldto see if the controller was theAutoCompleteSearchControllerMixin, and then doing special autocomplete logic. I've moved all of that logic to where we build the autocomplete instead.