Add a warning to stop launching on pub for DevTools version 2.8.0 #3464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacob314
reviewed
Oct 25, 2021
jacob314
reviewed
Oct 25, 2021
jacob314
reviewed
Oct 25, 2021
jacob314
reviewed
Oct 25, 2021
| return Material( | ||
| color: colorScheme.overlayShadowColor, | ||
| child: Center( | ||
| child: Container( |
There was a problem hiding this comment.
nit: can center be moved into container? Container can align to center.
There was a problem hiding this comment.
For some reason, this makes the Container full screen instead of the size of its content.
jacob314
approved these changes
Oct 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
showPubWarningflag will only be turned on a for a special release of DevTools 2.8.0 to pub. This ensures we will not mistakenly show this warning for DevTools 2.8.0 shipped in the SDK. When DevTools is launched from pub for a user that is on Flutter >= 2.8.0 or Dart >= 2.15.0, this overlay warning will show when the user opens DevTools and connects to their app.This warning will also show in the About DevTools menu.
Fixes #3433