Refactor InspectorServiceBase and ObjectGroupBase out of InspectorService and ObjectGroup #3465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/ObjectGroup This change refactors InspectorServiceBase & ObjectGroupBase out of InspectorService & ObjectGroup. In addition to cleaning up the codebase, this refactor allows for the sharing of some Inspector functionality outside of Flutter apps.
jacob314
reviewed
Oct 25, 2021
jacob314
reviewed
Oct 25, 2021
jacob314
reviewed
Oct 26, 2021
jacob314
reviewed
Oct 26, 2021
packages/devtools_app/lib/src/inspector/layout_explorer/flex/flex.dart
Outdated
Show resolved
Hide resolved
- Added empty line in ObjectGroupBase comment - Created object group accessors (which cast to ObjectGroup)
|
failing on known flake |
This was referenced Oct 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change refactors
InspectorServiceBaseandObjectGroupBaseout ofInspectorServiceandObjectGroup, respectively.In addition to cleaning up the codebase, this refactor allows for the sharing of some Inspector functionality outside of Flutter apps via the subclassing of these new base classes. This refactor should not introduce any functional changes to DevTools.