Don't register service worker when running DevTools locally #3476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacob314
reviewed
Oct 29, 2021
packages/devtools_app/web/index.html
Outdated
| function waitForActivation(serviceWorker) { | ||
| serviceWorker.addEventListener('statechange', () => { | ||
| if (serviceWorker.state == 'activated') { | ||
| if (window.location.hostname === 'localhost' || |
There was a problem hiding this comment.
checking for localhost doesn't seem safe. Could easily be running devtools from localhost in a release build.
There was a problem hiding this comment.
SG, modified to just check for index.ddc.html
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a check to see if DevTools is running locally in
index.html, which is determined by:localhostORindex.htmlfile is calledindex.ddc.htmlIf so, we skip the service worker registration step (before, this would fail after 4 seconds).
I've also caught any error coming from registering the service worker, and logging it to the console as a warning.