Improve inspecting large Map and List types
#3497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kenzieschmoll
approved these changes
Nov 17, 2021
|
hey @elliette. this is a great PR and those are great gifs. any chance you could retake the list screenshot w/o the debug banner? I'd find that useful. |
|
@csells - sure, here you go! Map: |
|
excellent! thanks very much. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work towards #2950
Creates "groupings" of items/entries for
Map/Listtypes if the number of children is greater than 100. Makes calls togetObjectwithoffsetandcountas themap/listis expanded (Note: we still preemptively callgetObjectfor one level below what has been expanded. This way toggling expansion shows the children instantaneously.)Demos:
Without this change, these large
Maps/Listswould cause DevTools to crash.List:
Map: