Refactors AutoDisposeMixin to have separate cancel methods for listeners, stream subscriptions, and focus nodes
#3540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elliette
commented
Dec 14, 2021
| @@ -158,8 +158,6 @@ class SnapshotFilterState extends State<SnapshotFilterDialog> | |||
| for (var key in oldFiltered.keys) { | |||
| oldFilteredLibraries[key] = oldFiltered[key].first.hide; | |||
| } | |||
|
|
|||
| cancel(); | |||
There was a problem hiding this comment.
The listeners this was canceling were removed in #2275, so this should be safe to remove.
kenzieschmoll
approved these changes
Dec 14, 2021
| @@ -160,7 +160,7 @@ class _ConsoleOutputState extends State<_ConsoleOutput> | |||
| @override | |||
| void didUpdateWidget(_ConsoleOutput oldWidget) { | |||
| if (oldWidget.lines != widget.lines) { | |||
| cancel(); | |||
| cancelListeners(); | |||
There was a problem hiding this comment.
not your fault, but let's move this to _initHelper to keep it grouped with where the listeners are added
| @@ -180,11 +180,12 @@ class ConsoleService extends Disposer { | |||
| } | |||
|
|
|||
| void vmServiceOpened(VmServiceWrapper service) { | |||
| cancel(); | |||
| cancelStreamSubscriptions(); | |||
There was a problem hiding this comment.
we need to cancel listeners here too since we are also adding an auto dispose listener
| @@ -207,7 +207,7 @@ class MemoryEventsPaneState extends State<MemoryEventsPane> | |||
| final themeData = Theme.of(context); | |||
| colorScheme = themeData.colorScheme; | |||
|
|
|||
| cancel(); | |||
| cancelListeners(); | |||
There was a problem hiding this comment.
again not your fault, but this looks like a bug below that we have a call to addAutoDisposeListener nested inside a listener for another addAutoDisposeListener call. Let's move the second call outside of the listener block
There was a problem hiding this comment.
SG, removed the nesting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3538
Follow up to #3532, this way we can use
autoDisposeFocusNodein widgets we weren't able to use it in before.Also renames the
autoDisposemethod toautoDisposeStreamSubscriptionfor clarity.