Enable new "Profile" and "Allocation Tracing" sub-tabs in Memory screen

[bkonyi]

Also removes the old "Allocations" tool and its relevant code.

[polina-c]

Please rename columns to be consistent with diff tab:
Size / Internal / External - > Total Shallow / Shallow Dart / Shallow Native

And in the documentation: https://github.com/flutter/devtools/blob/master/packages/devtools_app/lib/src/screens/memory/panes/allocation_profile/ALLOCATION_PROFILE.md

For total shallow reference this tooltip:

devtools/packages/devtools_app/lib/src/screens/memory/shared/heap/primitives.dart

Line 5 in b8672b0

const String shallowSizeColumnTooltip =

[polina-c]

The bug is still here: #4484
Can you fix it?

[polina-c]

And sorting by instances does not seem to work too:

[polina-c]

Tooltips for columns are the same in every group. We need to either to add tooltips for column groups (seems to be cleaner) or to have little different tooltips for the columns themselves.

[bkonyi]

@polina-c I'm going to follow up on this change with additional PRs that clean things up. Didn't want to put them all in one PR.

[bkonyi]

The bug is still here: #4484 Can you fix it?

And sorting by instances does not seem to work too:

Both of these are fixed by #4532.

[bkonyi]

Please rename columns to be consistent with diff tab: Size / Internal / External - > Total Shallow / Shallow Dart / Shallow Native

And in the documentation: https://github.com/flutter/devtools/blob/master/packages/devtools_app/lib/src/screens/memory/panes/allocation_profile/ALLOCATION_PROFILE.md

For total shallow reference this tooltip:

devtools/packages/devtools_app/lib/src/screens/memory/shared/heap/primitives.dart

Line 5 in b8672b0

const String shallowSizeColumnTooltip =

"Shallow Native" isn't necessarily correct as it's non-Dart memory and only as accurate as the values provided by the embedder (see the specification here). There's no requirement for the provided value to be deep/shallow, or for the embedder to provide any value (e.g., the Flutter engine no longer reports image data sizes via this field as it manages the lifecycle of images independently from the VM's garbage collector).

I'm also not convinced that it's necessary to change the headers to be this verbose when we can just update the tooltips to better explain that these are shallow memory values, especially when there's no retained memory column in the same context. I propose that we use the following instead:

• "Size" -> "Total Size" Tooltip: "The sum of the object type's total shallow memory consumption in the Dart heap and associated external (e.g., non-Dart heap) allocations"
• "Internal" -> "Dart Heap" Tooltip: "$shallowSizeColumnTooltip"
• "External" -> "External" Tooltip: "Non-Dart heap allocated memory associated with an object type"

[bkonyi]

Tooltips for columns are the same in every group. We need to either to add tooltips for column groups (seems to be cleaner) or to have little different tooltips for the columns themselves.

I don't think this is necessary, at least at this point, since only the Total column group will typically be displayed for the vast majority of users.

Also, I really appreciate the attention to detail, but it's better for my workflow to have new bugs filed for issues not directly related to the current PR and referenced in the PR comments and/or assigned to directly to me as requiring a follow up. That way we can keep discussions centralized in the issue tracker and not tied directly to a potentially closed / abandoned PR that can easily be lost, and I don't start encountering scope creep for individual PRs :-)

[kenzieschmoll]

"Size" -> "Total Size" Tooltip: "The sum of the object type's total shallow memory consumption in the Dart heap and associated external (e.g., non-Dart heap) allocations"
"Internal" -> "Dart Heap" Tooltip: "$shallowSizeColumnTooltip"
"External" -> "External" Tooltip: "Non-Dart heap allocated memory associated with an object type"

SGTM - does "Dart Heap" + "External" for an object = "Total Size"?

[bkonyi]

SGTM - does "Dart Heap" + "External" for an object = "Total Size"?

That's correct.