Update vm_service to 11.0.0 and finish profiling migration #5105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CoderDake
added a commit
to CoderDake/devtools
that referenced
this pull request
Jan 25, 2023
kenzieschmoll
approved these changes
Jan 25, 2023
CoderDake
changed the title
int to String
|
The tests should pass once the new test_core package is published |
bkonyi
approved these changes
Feb 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blocked waiting for https://dart-review.googlesource.com/c/sdk/+/279122 to be merged and be available on the latest flutter candidate.
Addresses some comments in: #2860
Details
This PR migrates vm_service to 11.0.0 in order to benefit from certain
ids beingStringinstead ofint.This finalizes the migration that will ensure that all recorded network requests show up in the Network tab. Previously integer overflows were causing those requests to be lost.
RELEASE_NOTE_EXCEPTION=Internal migration only