Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove export and source from memory screen. #5135

Merged
merged 23 commits into from Jan 31, 2023
Merged

Remove export and source from memory screen. #5135

merged 23 commits into from Jan 31, 2023

Conversation

polina-c
Copy link
Contributor

@polina-c polina-c commented Jan 29, 2023 •
edited

Fixes #5045

I postponed code clean up, because some code will be helpful for future implementation of offline mode.

@polina-c polina-c marked this pull request as ready for review January 29, 2023 01:46
@polina-c polina-c requested review from bkonyi and a team as code owners January 29, 2023 01:46
@bkonyi bkonyi mentioned this pull request Jan 30, 2023
Merged
@polina-c
Copy link
Contributor Author

I managed to mess up this PRs with another one (#5134). So, converting this to draft for now to land performance first.

@polina-c polina-c marked this pull request as draft January 30, 2023 16:16
@polina-c polina-c marked this pull request as ready for review January 30, 2023 19:15
kenzieschmoll
kenzieschmoll reviewed Jan 30, 2023
View reviewed changes
Copy link
Member

@kenzieschmoll kenzieschmoll left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should also delete controller.memorySource logic. This should not be needed for future implementation of offline mode since the offline snapshot will use a different instance of MemoryController

@polina-c
Copy link
Contributor Author

we should also delete controller.memorySource logic. This should not be needed for future implementation of offline mode since the offline snapshot will use a different instance of MemoryController

#5145

@kenzieschmoll kenzieschmoll mentioned this pull request Jan 30, 2023
Merged
kenzieschmoll
kenzieschmoll reviewed Jan 30, 2023
View reviewed changes
packages/devtools_app/lib/src/screens/memory/memory_controller.dart Outdated
Comment on lines 263 to 265
/// This flag will be needed for offline mode implementation.
bool offline = false;

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this actually will not be needed. We will use offlineController.offlineMode.value to check whether we are in offline mode or not.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I want to preserve all references to this variable, so that we do not forget to review them and decide what will be their behavior in offline mode.

kenzieschmoll
kenzieschmoll reviewed Jan 30, 2023
View reviewed changes
packages/devtools_app/test/memory/memory_screen_test.dart
);
});

testWidgetsWithWindowSize('Chart Select Hover Test', windowSize,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why are we removing this test? seems we just need to switch the canned data to be loaded as live data instead of offline data, and then we can still test the chart hover card

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test is broken. It does not test hover card. There is no card on the image.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And there is Terry's TODO in the comments.

@polina-c polina-c merged commit 8217489 into flutter:master Jan 31, 2023
@polina-c polina-c deleted the export branch January 31, 2023 01:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacob314 jacob314 jacob314 left review comments

@bkonyi bkonyi bkonyi left review comments

@kenzieschmoll kenzieschmoll kenzieschmoll approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove the Source selector on the memory screen
4 participants
@polina-c @jacob314 @bkonyi @kenzieschmoll