Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug with flame chart mouse position calculation #5676

Merged
merged 3 commits into from Apr 19, 2023
Merged

Fix bug with flame chart mouse position calculation #5676

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
28c0d1b
Fix bug with flame chart mouse position calculation
kenzieschmoll Apr 19, 2023
cade499
release notes
kenzieschmoll Apr 19, 2023
a9f91e1
add pr link
kenzieschmoll Apr 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/devtools_app/lib/src/shared/charts/flame_chart.dart
View file
Open in desktop
Expand Up @@ -418,7 +418,8 @@ abstract class FlameChartState<T extends FlameChart,
/// Returns -1 if the row index is out of range for [rows].
int _rowIndexForY(double dy) {
final topPaddingHeight = rowOffsetForTopPadding * sectionSpacing;
final rowIndex = ((dy - topPaddingHeight) ~/ rowHeightWithPadding) +
final adjustedDy = verticalControllerGroup.offset + dy;
final rowIndex = ((adjustedDy - topPaddingHeight) ~/ rowHeightWithPadding) +
rowOffsetForTopPadding;
if (rowIndex < 0 || rowIndex >= rows.length) {
return -1;
Expand Down
2 changes: 1 addition & 1 deletion packages/devtools_app/release_notes/NEXT_RELEASE_NOTES.md
View file
Open in desktop
Expand Up @@ -15,7 +15,7 @@ TODO: Remove this section if there are not any general updates.
TODO: Remove this section if there are not any general updates.

## CPU profiler updates
TODO: Remove this section if there are not any general updates.
* Fix bug with CPU flame chart selection and tooltips - [#5676](https://github.com/flutter/devtools/pull/5676)

## Memory updates
TODO: Remove this section if there are not any general updates.
Expand Down