Fix expression evaluation autocomplete bug #5717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elliette
commented
Apr 25, 2023
| final searchingValue = _autoCompleteController.search; | ||
|
|
||
| _autoCompleteController.clearCurrentSuggestion(); | ||
|
|
||
| if (searchingValue.isNotEmpty) { | ||
| if (_autoCompleteController.selectTheSearch) { | ||
| _autoCompleteController.resetSearch(); |
There was a problem hiding this comment.
Resetting the search term here was the crux of the bug. This would clear whatever the user had already inputted.
kenzieschmoll
approved these changes
Apr 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5710
Work towards #5703
Fixes the bug where selecting a field during expression evaluation would replace everything in the input, instead of everything up to the last dot (eg.
myClass.someMetho-> enter to acceptsomeMethodwould replace all ofmyClass.someMethowith justsomeMethod).