New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for static tooling in DevTools and add a "Home" screen #6010
Conversation
2e9394a
to
4bbbce3
Compare
4bbbce3
to
56ff647
Compare
@@ -275,48 +236,4 @@ void main() { | |||
}, | |||
); | |||
}); | |||
|
|||
group('VMFlagsDialog', () { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
moved to vm_flag_widgets_test.dart
From @polina-c
Right now this is implemented so that only tabs that are available without an app connection will show up when there is no connected app (static mode). Then when an app connects, we will show other supported tabs. The screens are defined in a static order right now (see https://github.com/flutter/devtools/blob/master/packages/devtools_app/lib/src/app.dart#L478), so to keep the ordering consistent, we'd have to order all tabs that support static tooling first, and IMO that ordering won't always make sense. The most commonly used tools should still be ordered at the front of the list, even if that means the static tools are now inserted back to their rightful position amongst the entire set of screens. |
This PR refactors the DevTools landing or "connect" screen to be a screen that is available from the tab bar, with and without a connected app.
The tab bar shows only tools that are available, so runtime tabs will be hidden when there is no connected app, but will appear once a connection is established.
Note: The blue footer in this gif that indicates connection state will be implemented as a follow up PR.
Fixes #5990