New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Widget inspector should operate on main isolate, not selected isolate #6434

Merged

auto-submit merged 9 commits into flutter:master from CoderDake:inspector-isolate-selection

Sep 25, 2023

Contributor

CoderDake commented Sep 20, 2023 •

edited

Fixes #6357


          change to using main isolate in inspector

7b60c8a

CoderDake added the run-dcm-workflow label


          release notes

4bc73c6

CoderDake changed the title ~~change to using main isolate in inspector~~ Widget inspector should operate on main isolate, not selected isolate

CoderDake requested a review from kenzieschmoll

September 20, 2023 19:01

CoderDake marked this pull request as ready for review

September 20, 2023 19:01

CoderDake requested a review from a team as a code owner

September 20, 2023 19:01

kenzieschmoll reviewed

View reviewed changes

packages/devtools_app_shared/lib/src/service/eval_on_dart_library.dart Outdated Show resolved Hide resolved


          widget inspector should only use the main isolate

43ca634

kenzieschmoll reviewed

View reviewed changes

packages/devtools_app_shared/lib/src/service/eval_on_dart_library.dart Outdated Show resolved Hide resolved


          use isolate param

0fb9bc2

kenzieschmoll reviewed

View reviewed changes

packages/devtools_app/lib/src/shared/diagnostics/inspector_service.dart Outdated Show resolved Hide resolved

CoderDake added 2 commits

September 22, 2023 10:12


          Merge remote-tracking branch 'upstream/master' into inspector-isolate…

6adc209

…-selection


          Pass the eval isolate in from higher up

8fdc10c

kenzieschmoll reviewed

View reviewed changes

packages/devtools_app/lib/src/shared/diagnostics/inspector_service.dart Outdated Show resolved Hide resolved

kenzieschmoll reviewed

View reviewed changes

packages/devtools_app/lib/src/shared/diagnostics/inspector_service.dart Outdated Show resolved Hide resolved

CoderDake added 2 commits

September 25, 2023 15:44


          pass isolate the proper way :face_palm:

a5d7f7f


          extra line

22a450b

kenzieschmoll reviewed

View reviewed changes

packages/devtools_app/lib/src/shared/diagnostics/inspector_service.dart Outdated Show resolved Hide resolved

kenzieschmoll reviewed

View reviewed changes

packages/devtools_app/lib/src/shared/diagnostics/inspector_service.dart Outdated Show resolved Hide resolved


          super clean

9fe55f7

kenzieschmoll approved these changes

View reviewed changes

CoderDake added the autosubmit label

auto-submit bot merged commit 54bb6fa into flutter:master

23 checks passed

CoderDake deleted the inspector-isolate-selection branch

September 25, 2023 21:17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment