Protect service restoration against SentinelException #6451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
packages/devtools_app_shared/lib/src/service/service_extension_manager.dart
Outdated
Show resolved
Hide resolved
CoderDake
commented
Sep 25, 2023
packages/devtools_app_shared/lib/src/service/service_extension_manager.dart
Outdated
Show resolved
Hide resolved
kenzieschmoll
approved these changes
Sep 25, 2023
CoderDake
added
the
autosubmit
auto-submit
bot
removed
the
autosubmit
|
auto label is removed for flutter/devtools/6451, due to - The status or check suite devtools_app integration-test integration_dart2js - flutter-web - shard 2/2 has failed. Please fix the issues identified (or deflake) before re-applying this label. |
CoderDake
added
the
autosubmit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6449
When spamming hot restart these service refreshes commonly throw SentinelExceptions. Meaning they stopped existing while being called.
This PR handles those expections with a do nothing, since we will need to recall these for the next service to start anyways