Fix DevTools extensions not being resolved when app's Dart entrypoint is located in integration_test directory
#6644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… is integration_test/*.dart
bartekpacia
added a commit
to leancodepl/patrol
that referenced
this pull request
Nov 2, 2023
This is a temporary workaround for flutter/devtools#6644
CoderDake
requested review from
kenzieschmoll
and removed request for
CoderDake
kenzieschmoll
approved these changes
Nov 2, 2023
There was a problem hiding this comment.
LGTM, thanks for bringing this issue to our attention. Before the next release of DevTools, I'm going to try to fix this for all cases (including integration_test) by addressing the TODO in this method:
// TODO(kenz): for robustness, consider sending the root library uri to the
// server and having the server look for the package folder that contains the
// `.dart_tool` directory.
|
Thanks for quick review @kenzieschmoll. I fixed code formatting, should be good now. |
DanTup
reviewed
Nov 2, 2023
Comment on lines
167
to
172
| final libDirectoryRegExp = RegExp(r'\/lib\/[^\/.]*.dart'); | ||
| final libDirectoryIndex = fileUri.indexOf(libDirectoryRegExp); | ||
| final integrationTestDirectoryRegExp = | ||
| RegExp(r'\/integration_test\/[^\/.]*.dart'); | ||
| final integrationTestDirectoryIndex = | ||
| fileUri.indexOf(integrationTestDirectoryRegExp); |
There was a problem hiding this comment.
Maybe this could be a single regex, something like:
RegExp(r'\/(lib|integration_test|test|bin)\/[^\/.]*.dart');There was a problem hiding this comment.
let's see - I pushed the changes
kenzieschmoll
approved these changes
Nov 3, 2023
|
You'll need to merge master to get this to pass the tests. Also, can you add an entry to NEXT_RELEASE_NOTES.md in the General section? |
|
Thanks - done! |
kenzieschmoll
pushed a commit
that referenced
this pull request
Nov 7, 2023
… is located in `integration_test` directory (#6644)
This was referenced Nov 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm developing a DevTools extension that's meant to be used during integration testing. That's why our app's entrypoint is
integration_test/test_bundle.dart, notlib/main.dartor similar.Unfortunately, when the app is started with
integration_test/*.dartentrypoint, no DevTools extensions were loaded and we were seeing the following errors:List which issues are fixed by this PR.
I wrote about this issue on Flutter team's Discord (link).
Pre-launch Checklist
///).If you need help, consider asking for help on Discord.