New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Densify DevTools UI #7030
Densify DevTools UI #7030
Conversation
This PR does have release notes, but it appears the release notes check may not be working. |
@@ -318,7 +318,7 @@ class _NotificationMessage extends StatelessWidget { | |||
@override | |||
Widget build(BuildContext context) { | |||
final theme = Theme.of(context); | |||
final textStyle = theme.textTheme.bodyMedium; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you document in our style guide not to use theme.textTheme.bodyMedium
Looks like a big improvement! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -738,9 +737,9 @@ class VmServiceObjectLink extends StatelessWidget { | |||
|
|||
final TextStyle style; | |||
if (isServiceObject) { | |||
style = theme.fixedFontLinkStyle; | |||
style = theme.linkTextStyle; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are these still using monospace fonts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are right. We assumed a monospace font for calculating the width of the variable width columns. Other options:
@Piinks does the new Flutter table you built handle variable width columns well? TL;DR is we used a monospace font so that we could accurately guess the size of a text display ( |
If you mean does the column automatically size itself based on the content in a given cell? No. That would mean we would need to lay out every cell for a given column to determine how wide it should be, which would make the table not lazy and have poor performance. However, there are many ways to define the size of a column or row, all of the subclasses of TableSpanExtent are listed here: https://pub.dev/documentation/two_dimensional_scrollables/latest/table_view/TableSpanExtent-class.html |
I think option 3 makes sense if we add back in tooltips or another affordance so there is a way to view the full content without truncation. |
This discussed table changes are implemented as a separate PR: #7033 |
Many styling issues were resolved by changing constants in
theme.dart
and applying styling to the default textTheme.In this PR we set the default font size for
textTheme.bodyMedium
, which is the default font style applied to allText
widgets.Fixes #6761
Some before (left) and after (right) examples: