Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not show release notes in the Flutter sidebar. #7166

Merged
merged 3 commits into from Feb 5, 2024
Merged

Do not show release notes in the Flutter sidebar. #7166

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a3cf0a4
Do not show release notes in the Flutter sidebar.
kenzieschmoll Feb 5, 2024
63d4523
r notes
kenzieschmoll Feb 5, 2024
34558a6
fix test
kenzieschmoll Feb 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
13 changes: 13 additions & 0 deletions packages/devtools_app/lib/src/framework/release_notes/release_notes.dart
View file
Open in desktop
Expand Up @@ -4,14 +4,18 @@

import 'dart:async';

import 'package:devtools_app_shared/utils.dart';
import 'package:devtools_shared/devtools_shared.dart';
import 'package:flutter/material.dart';
import 'package:http/http.dart' as http;
import 'package:logging/logging.dart';

import '../../../devtools.dart' as devtools;
import '../../shared/primitives/url_utils.dart';
import '../../shared/server/server.dart' as server;
import '../../shared/side_panel.dart';
import '../../shared/utils.dart';
import '../../standalone_ui/standalone_screen.dart';

final _log = Logger('release_notes');

Expand Down Expand Up @@ -57,6 +61,15 @@ class ReleaseNotesController extends SidePanelController {
}

void _maybeShowReleaseNotes() async {
final currentUrl = getWebUrl();
final currentPage =
currentUrl != null ? extractCurrentPageFromUrl(currentUrl) : null;
if (isEmbedded() &&
currentPage == StandaloneScreenType.vsCodeFlutterPanel.name) {
// Do not show release notes in the Flutter sidebar.
return;
}

SemanticVersion previousVersion = SemanticVersion();
if (server.isDevToolsServerAvailable) {
final lastReleaseNotesShownVersion =
Expand Down
2 changes: 1 addition & 1 deletion packages/devtools_app/release_notes/NEXT_RELEASE_NOTES.md
View file
Open in desktop
Expand Up @@ -54,7 +54,7 @@ TODO: Remove this section if there are not any general updates.

## VS Code Sidebar updates

TODO: Remove this section if there are not any general updates.
* Do not show DevTools release notes in the Flutter sidebar. - [#7166](https://github.com/flutter/devtools/pull/7166)

## DevTools Extension updates

Expand Down
3 changes: 3 additions & 0 deletions packages/devtools_app/test/shared/release_notes_test.dart
View file
Open in desktop
Expand Up @@ -3,13 +3,16 @@
// found in the LICENSE file.

import 'package:devtools_app/devtools_app.dart';
import 'package:devtools_app_shared/ui.dart';
import 'package:devtools_app_shared/utils.dart';
import 'package:devtools_shared/devtools_shared.dart';
import 'package:flutter_test/flutter_test.dart';

void main() {
group('$ReleaseNotesController', () {
late ReleaseNotesController controller;
setUp(() {
setGlobal(IdeTheme, IdeTheme());
debugTestReleaseNotes = true;
controller = ReleaseNotesController();
});
Expand Down