Modify DevToolsExtensionConfig model to handle static extensions #7602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
bkonyi
approved these changes
Apr 17, 2024
| @@ -4,7 +4,12 @@ | |||
| * **Breaking change:** rename `ExtensionsApi.extensionRootPathPropertyName` | |||
| to `ExtensionsApi.packageRootUriPropertyName`, and modify the String value | |||
| for the parameter from 'rootPath' to 'packageRootUri'. | |||
|
|
|||
| * **Breaking change:** add new required JSON fields "devtoolsOptionsUri" and | |||
There was a problem hiding this comment.
How are we planning on handling these breaking changes for existing extensions in the ecosystem?
There was a problem hiding this comment.
These breaking changes are for the DevTools --> DevTools server API and shouldn't be called directly by DevTools extensions. The devtools_extensions and devtools_app_shared packages will be bumped to this new devtools_shared version in their own major version bumps.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work towards #7569