Skip to content

Commit

Permalink
Skip failing MultisampleTest on Nexus 6P and NVIDIA Shield TV
Browse files Browse the repository at this point in the history
Bug: angleproject:3464, angleproject:3470
Change-Id: Ie864118ceebfc0d72aa95928a02ef0939be5b89a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1620992
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
  • Loading branch information
y-novikov authored and Commit Bot committed May 21, 2019
1 parent affc252 commit 01f98cb
Showing 1 changed file with 6 additions and 2 deletions.
8 changes: 6 additions & 2 deletions src/tests/gl_tests/MultisampleTest.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -29,9 +29,9 @@ class MultisampleTest : public ANGLETest

ASSERT_TRUE(eglInitialize(mDisplay, nullptr, nullptr) == EGL_TRUE);

// Nexus 5X fails to eglMakeCurrent with a config it advertises it supports.
// Nexus 5X and 6P fail to eglMakeCurrent with a config they advertise they support.
// http://anglebug.com/3464
ANGLE_SKIP_TEST_IF(IsNexus5X());
ANGLE_SKIP_TEST_IF(IsNexus5X() || IsNexus6P());

// Find a config that uses RGBA8 and allows 4x multisampling.
const EGLint configAttributes[] = {
Expand Down Expand Up @@ -129,6 +129,8 @@ class MultisampleTest : public ANGLETest
TEST_P(MultisampleTest, Point)
{
ANGLE_SKIP_TEST_IF(!mMultisampledConfigExists);
// http://anglebug.com/3470
ANGLE_SKIP_TEST_IF(IsAndroid() && IsNVIDIAShield() && IsOpenGLES());

constexpr char kPointsVS[] = R"(precision highp float;
attribute vec4 a_position;
Expand Down Expand Up @@ -227,6 +229,8 @@ TEST_P(MultisampleTest, Line)
TEST_P(MultisampleTest, Triangle)
{
ANGLE_SKIP_TEST_IF(!mMultisampledConfigExists);
// http://anglebug.com/3470
ANGLE_SKIP_TEST_IF(IsAndroid() && IsNVIDIAShield() && IsOpenGLES());

ANGLE_GL_PROGRAM(program, essl1_shaders::vs::Simple(), essl1_shaders::fs::Red());
glUseProgram(program);
Expand Down

0 comments on commit 01f98cb

Please sign in to comment.